Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 743623002: Move ProxyResolutionServiceProvider to chromeos/dbus/services (Closed)

Created:
6 years, 1 month ago by hashimoto
Modified:
6 years, 1 month ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, hashimoto+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ProxyResolutionServiceProvider to chromeos/dbus/services Introduce ProxyResolverDelegate to get rid of dependencies to content/ and chrome/ BUG=429354 Committed: https://crrev.com/54d1820fb72cc0521d3d291cc2a882c6e149ceee Cr-Commit-Position: refs/heads/master@{#304967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -633 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +4 lines, -2 lines 0 comments Download
A chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.h View 1 chunk +28 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc View 1 chunk +22 lines, -0 lines 0 comments Download
D chrome/browser/chromeos/dbus/proxy_resolution_service_provider.h View 1 chunk +0 lines, -151 lines 0 comments Download
D chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc View 1 chunk +0 lines, -280 lines 0 comments Download
D chrome/browser/chromeos/dbus/proxy_resolution_service_provider_unittest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
A + chromeos/dbus/services/proxy_resolution_service_provider.h View 7 chunks +23 lines, -6 lines 0 comments Download
A + chromeos/dbus/services/proxy_resolution_service_provider.cc View 5 chunks +13 lines, -11 lines 0 comments Download
A + chromeos/dbus/services/proxy_resolution_service_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
hashimoto
6 years, 1 month ago (2014-11-19 09:29:15 UTC) #2
Daniel Erat
lgtm
6 years, 1 month ago (2014-11-19 15:04:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/743623002/1
6 years, 1 month ago (2014-11-20 03:17:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 03:59:44 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 04:00:30 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/54d1820fb72cc0521d3d291cc2a882c6e149ceee
Cr-Commit-Position: refs/heads/master@{#304967}

Powered by Google App Engine
This is Rietveld 408576698