Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 743603004: Make skydb chromoting aware (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
ojan, abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Make skydb chromoting aware Presumably we should push this logic down into mojo instead of hacking around this at the script level. But at least this makes skydb work better for now. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c71e99bbfaa19f3cef550f48b5dba29cc6ac2984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M sky/tools/skydb View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
eseidel
6 years, 1 month ago (2014-11-19 17:18:38 UTC) #1
ojan
lgtm
6 years, 1 month ago (2014-11-19 17:40:18 UTC) #3
eseidel
Committed patchset #1 (id:1) manually as c71e99bbfaa19f3cef550f48b5dba29cc6ac2984 (presubmit successful).
6 years, 1 month ago (2014-11-19 17:46:47 UTC) #4
abarth-chromium
6 years, 1 month ago (2014-11-19 18:05:52 UTC) #6
Message was sent while issue was closed.
Neat!

Powered by Google App Engine
This is Rietveld 408576698