Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 7436001: WebUI TaskManager: make it default on touch UI (Closed)

Created:
9 years, 5 months ago by yoshiki
Modified:
9 years, 5 months ago
Reviewers:
mazda
CC:
chromium-reviews
Visibility:
Public.

Description

WebUI TaskManager: make it default on touch UI BUG=chromium-os:13885 TEST=manually on chromium-os Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93363

Patch Set 1 #

Total comments: 2

Patch Set 2 : Enclose the block with one if-else clause. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yoshiki
9 years, 5 months ago (2011-07-19 09:30:14 UTC) #1
mazda
http://codereview.chromium.org/7436001/diff/1/chrome/browser/ui/views/frame/browser_view.cc File chrome/browser/ui/views/frame/browser_view.cc (right): http://codereview.chromium.org/7436001/diff/1/chrome/browser/ui/views/frame/browser_view.cc#newcode1055 chrome/browser/ui/views/frame/browser_view.cc:1055: #if !defined(TOUCH_UI) How about enclosing the block with one ...
9 years, 5 months ago (2011-07-19 10:05:07 UTC) #2
yoshiki
http://codereview.chromium.org/7436001/diff/1/chrome/browser/ui/views/frame/browser_view.cc File chrome/browser/ui/views/frame/browser_view.cc (right): http://codereview.chromium.org/7436001/diff/1/chrome/browser/ui/views/frame/browser_view.cc#newcode1055 chrome/browser/ui/views/frame/browser_view.cc:1055: #if !defined(TOUCH_UI) On 2011/07/19 10:05:07, mazda wrote: > How ...
9 years, 5 months ago (2011-07-20 07:38:59 UTC) #3
mazda
9 years, 5 months ago (2011-07-20 12:04:54 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698