Issue 743533003: Revert "Forward declaration for Isolate / Platform in libplatform.h." and "Fixes d8 on windows foll…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 743533003: Revert "Forward declaration for Isolate / Platform in libplatform.h." and "Fixes d8 on windows foll… (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer

Modified:
6 years, 1 month ago

Reviewers:
bulach, Michael Achenbach

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Revert "Forward declaration for Isolate / Platform in libplatform.h." and "Fixes d8 on windows following.". This reverts commit 0f57ce8f1a3d6b4f3a4b65739d719b8467ff5d9c. and 3245b8cb832f4a948aff9fb1c271cc08c4690d3b for breaking Chromium compile. TBR=machenbach@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/21580e7b791660e241b5c18e50eb093d46563269

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -9 lines)			Patch
M	include/libplatform/libplatform.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	samples/lineprocessor.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	samples/shell.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/d8.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/unittests/run-all-unittests.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Benedikt Meurer

Committed patchset #1 (id:1) manually as 21580e7b791660e241b5c18e50eb093d46563269 (tree was closed).

6 years, 1 month ago (2014-11-19 07:28:20 UTC) #2

Michael Achenbach

6 years, 1 month ago (2014-11-19 08:24:55 UTC) #4

Message was sent while issue was closed.

lgtm. I'll work on adding a chromium compile trybot to our CQ so that these
things can't slip through...