Issue 74353002: Fix some runtime errors in mojo Connector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 74353002: Fix some runtime errors in mojo Connector. (Closed)

Created:
7 years, 1 month ago by Ben Goodger (Google)

Modified:
7 years, 1 month ago

Reviewers:
darin (slow to review), viettrungluu

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix some runtime errors in mojo Connector. R=viettrungluu BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235630

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	mojo/public/bindings/lib/connector.cc	View		2 chunks	+8 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

darin (slow to review)

LGTM I guess GCC's version of std::vector does not complain about dereferencing the first element ...

7 years, 1 month ago (2013-11-15 22:52:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/74353002/1

7 years, 1 month ago (2013-11-16 06:51:41 UTC) #3

Message was sent while issue was closed.

Change committed as 235630