Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 743463003: Attempt #4 to convert telemetry to the typ framework. (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Attempt #4 to convert telemetry to the typ framework. This switches telemetry to use the typ python testing framework, which should allow us to run tests in parallel. The prior attempt was foiled by tools/chrome_proxy not having been updated; this attempt includes that change. R=dtu@chromium.org BUG=388256 = Committed: https://crrev.com/9af6a9ac4b74e30551554793991a1e99db82aa66 Cr-Commit-Position: refs/heads/master@{#304878}

Patch Set 1 #

Patch Set 2 : fix run_tests_unittest failures, remove debug logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -520 lines) Patch
M tools/chrome_proxy/run_tests View 1 1 chunk +13 lines, -10 lines 0 comments Download
M tools/perf/run_tests View 1 1 chunk +13 lines, -9 lines 0 comments Download
M tools/telemetry/PRESUBMIT.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/telemetry/bootstrap_deps View 1 chunk +17 lines, -30 lines 0 comments Download
M tools/telemetry/run_tests View 1 1 chunk +13 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/decorators.py View 3 chunks +63 lines, -15 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/browser_test_case.py View 1 chunk +33 lines, -12 lines 0 comments Download
D tools/telemetry/telemetry/unittest_util/json_results.py View 1 chunk +0 lines, -247 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_chromeos_tests.py View 2 chunks +18 lines, -26 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_tests.py View 1 4 chunks +115 lines, -143 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_tests_unittest.py View 1 2 chunks +18 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 4 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Dirk Pranke
Dave, please take another look and see if things look okay? I would've uploaded the ...
6 years, 1 month ago (2014-11-19 00:29:31 UTC) #1
dtu
lgtm
6 years, 1 month ago (2014-11-19 00:33:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/743463003/20001
6 years, 1 month ago (2014-11-19 02:28:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/25090)
6 years, 1 month ago (2014-11-19 02:35:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/743463003/20001
6 years, 1 month ago (2014-11-19 20:06:20 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-19 20:27:19 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9af6a9ac4b74e30551554793991a1e99db82aa66 Cr-Commit-Position: refs/heads/master@{#304878}
6 years, 1 month ago (2014-11-19 20:28:10 UTC) #10
tommycli
6 years, 1 month ago (2014-11-19 23:55:09 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/730183003/ by tommycli@chromium.org.

The reason for reverting is: Sorry, this broke the bot:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16871.

Powered by Google App Engine
This is Rietveld 408576698