Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: components/browser_watcher.gypi

Issue 743463002: Browser watcher, part deux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher.gypi
diff --git a/components/browser_watcher.gypi b/components/browser_watcher.gypi
index 87db22e4d865d25ceae364cd3966656856fb4604..bf9d9da1584390ec0a5f19256d968ac0387b87e9 100644
--- a/components/browser_watcher.gypi
+++ b/components/browser_watcher.gypi
@@ -7,6 +7,8 @@
['OS=="win"', {
'targets': [
{
+ # This is a separate lib to minimize the dependencies for its
erikwright (departed) 2014/11/18 20:00:05 personally I find the architecture self-explanator
Sigurður Ásgeirsson 2014/11/18 21:18:56 I've seen plenty of build configuration regression
+ # hosting binary "chrome_watcher.dll".
'target_name': 'browser_watcher_lib',
'type': 'static_library',
'sources': [
@@ -17,6 +19,19 @@
'../base/base.gyp:base',
],
},
+ {
+ # Users of the watcher link this target.
+ 'target_name': 'browser_watcher_client',
+ 'type': 'static_library',
+ 'sources': [
+ 'browser_watcher/watcher_client_win.cc',
+ 'browser_watcher/watcher_client_win.h',
+ ],
+ 'dependencies': [
+ 'browser_watcher_lib',
+ '../base/base.gyp:base',
+ ],
+ },
],
}
],
« no previous file with comments | « no previous file | components/browser_watcher/watcher_client_win.h » ('j') | components/browser_watcher/watcher_client_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698