pkg/compiler/lib/src/js_backend/namer.dart - Issue 743383002: Redo "Revert "Encode super calls via extra properties on prototypes.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 743383002: Redo "Revert "Encode super calls via extra properties on prototypes."" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/minify_namer.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/namer.dart

diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart

index 0fe858bd225d1be9097935c12a968c4d74cf2962..4eff34a459a1a27cfae6151df1b119eab7803b15 100644

--- a/pkg/compiler/lib/src/js_backend/namer.dart

+++ b/pkg/compiler/lib/src/js_backend/namer.dart

@@ -220,7 +220,6 @@ class Namer implements ClosureNamer {

final String currentIsolate = r'$';

final String getterPrefix = r'get$';

final String setterPrefix = r'set$';

- final String superPrefix = r'super$';

final String metadataField = '@';

final String callPrefix = 'call';

final String callCatchAllName = r'call$catchAll';

@@ -810,14 +809,6 @@ class Namer implements ClosureNamer {

// TODO(ahe): Remove this method. Use get getNameOfMember instead.

String getNameOfInstanceMember(Element member) => getNameX(member);

- String getNameOfAliasedSuperMember(Element member) {

- ClassElement superClass = member.enclosingClass;

- String className = getNameOfClass(superClass);

- String memberName = getNameOfMember(member);

- String proposal = "$superPrefix$className\$$memberName";

- return getMappedInstanceName(proposal);

- }

String getNameOfMember(Element member) => getNameX(member);

String getNameOfGlobalField(VariableElement field) => getNameX(field);