chrome/browser/resources/chromeos/chromevox/chromevox.gyp - Issue 743273002: Various changes required to support ChromeVox Next to read Views and Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox.gyp

Issue 743273002: Various changes required to support ChromeVox Next to read Views and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/component_loader.cc ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js » ('j') | chrome/common/extensions/api/_manifest_features.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox.gyp

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox.gyp b/chrome/browser/resources/chromeos/chromevox/chromevox.gyp

index 760675fe4b81ef4895632653b72675c95b5856ff..ac3f1dddc3ed50ffd06f0cf54d76a1e51b9b318d 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox.gyp

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox.gyp

@@ -24,8 +24,6 @@

'type': 'none',

'dependencies': [

'chromevox_resources',

- 'chromevox1_manifest',

- 'chromevox1_guest_manifest',

'chromevox2_manifest',

dmazzoni 2014/11/20 21:37:20 It's a little confusing to reference chromevox2_ma

'chromevox2_guest_manifest',

@@ -156,6 +154,7 @@

'includes': ['generate_deps.gypi'],

+ # Used for webstore releases.

{

'target_name': 'chromevox1_manifest',

dmazzoni 2014/11/20 21:37:20 Maybe this one should be chromevox_webstore_manife

'type': 'none',

@@ -165,19 +164,10 @@

'includes': [ 'generate_manifest.gypi', ],

{

- 'target_name': 'chromevox1_guest_manifest',

- 'type': 'none',

- 'variables': {

- 'output_manifest_path': '<(chromevox_dest_dir)/manifest_guest.json',

- 'is_guest_manifest': 1,

- },

- 'includes': [ 'generate_manifest.gypi', ],

- },

- {

'target_name': 'chromevox2_manifest',

'type': 'none',

'variables': {

- 'output_manifest_path': '<(chromevox_dest_dir)/manifest_next.json',

+ 'output_manifest_path': '<(chromevox_dest_dir)/manifest.json',

'is_chromevox_next': 1,

'includes': [ 'generate_manifest.gypi', ],

@@ -186,7 +176,7 @@

'target_name': 'chromevox2_guest_manifest',

'type': 'none',

'variables': {

- 'output_manifest_path': '<(chromevox_dest_dir)/manifest_next_guest.json',

+ 'output_manifest_path': '<(chromevox_dest_dir)/manifest_guest.json',

'is_guest_manifest': 1,

'is_chromevox_next': 1,