chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc - Issue 743273002: Various changes required to support ChromeVox Next to read Views and Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc

Issue 743273002: Various changes required to support ChromeVox Next to read Views and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ready with changes for flip (SpokenFeedbackTest.* pass). Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/accessibility/ax_root_obj_wrapper.cc ('k') | chrome/common/extensions/api/_manifest_features.json » ('j') | chrome/common/extensions/api/_manifest_features.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc

diff --git a/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc b/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc

index 66a0fd499f8def3d63dfad405b4ada7c4b111cbc..a86e10b2d2385cf2af2fa2d2b2d2d25226058bb5 100644

--- a/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc

+++ b/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc

@@ -23,6 +23,7 @@

#include "chrome/browser/signin/signin_error_notifier_factory_ash.h"

#include "chrome/browser/speech/tts_controller.h"

#include "chrome/browser/sync/sync_error_notifier_factory_ash.h"

+#include "chrome/browser/ui/ash/accessibility/automation_manager_ash.h"

#include "chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.h"

#include "chrome/browser/ui/ash/media_delegate_chromeos.h"

#include "chrome/browser/ui/ash/session_state_delegate_chromeos.h"

@@ -182,6 +183,8 @@ class AccessibilityDelegateImpl : public ash::AccessibilityDelegate {

profile, l10n_util::GetStringUTF8(IDS_A11Y_ALERT_WINDOW_NEEDED));

SendControlAccessibilityNotification(

ui::AX_EVENT_ALERT, &event);

+ AutomationManagerAsh::GetInstance()->HandleAlert(

+ profile, l10n_util::GetStringUTF8(IDS_A11Y_ALERT_WINDOW_NEEDED));

break;

}

case ui::A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED: {

@@ -190,6 +193,9 @@ class AccessibilityDelegateImpl : public ash::AccessibilityDelegate {

IDS_A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED));

SendControlAccessibilityNotification(

ui::AX_EVENT_ALERT, &event);

+ AutomationManagerAsh::GetInstance()->HandleAlert(

+ profile, l10n_util::GetStringUTF8(

+ IDS_A11Y_ALERT_WINDOW_OVERVIEW_MODE_ENTERED));

break;

}

case ui::A11Y_ALERT_NONE: