Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 7432005: Merge 91249 - Fix microphone icon placement in speech input control for dir=rtl. (Closed)

Created:
7 years, 11 months ago by jeremy
Modified:
7 years, 11 months ago
Reviewers:
jeremy
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/
Visibility:
Public.

Description

Merge 91249 - Fix microphone icon placement in speech input control for dir=rtl. https://bugs.webkit.org/show_bug.cgi?id=64668 Reviewed by Dimitri Glazkov. Source/WebCore: Modify default stylesheet to propagate dir=rtl from the outer input control to the shadow DOM container. This makes the microphone icon appear on the left for dir=rtl, which is the desired behavior. Test: fast/speech/speech-bidi-rendering.html * css/html.css: (input[x-webkit-speech][dir=rtl]::-webkit-textfield-decoration-container): LayoutTests: Added test that verifies placement of microphone icon for dir=rtl. * fast/speech/speech-bidi-rendering.html: Added. * platform/mac/fast/speech/speech-bidi-rendering-expected.png: Added. * platform/mac/fast/speech/speech-bidi-rendering-expected.txt: Added. TBR=jeremy@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14894 lines, -0 lines) Patch
A + LayoutTests/fast/speech/speech-bidi-rendering.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/chromium/test_expectations.txt View 1 chunk +194 lines, -1 line 0 comments Download
M Source/WebCore/ChangeLog View 2 chunks +14697 lines, -0 lines 0 comments Download
M Source/WebCore/css/html.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jeremy
7 years, 11 months ago (2011-07-19 14:57:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698