Source/web/ServiceWorkerGlobalScopeProxy.h - Issue 743153002: [DevTools] Show stack trace for exceptions in dedicated workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeProxy.h

Issue 743153002: [DevTools] Show stack trace for exceptions in dedicated workers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@worker-capture-stack

Patch Set: Rebased Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ServiceWorkerGlobalScopeProxy.h

diff --git a/Source/web/ServiceWorkerGlobalScopeProxy.h b/Source/web/ServiceWorkerGlobalScopeProxy.h

index 20fb8f5afe8f32503f0bbb3a25979bf8af49e909..708e8f40632e96246000d752be1fe7cff0d11b92 100644

--- a/Source/web/ServiceWorkerGlobalScopeProxy.h

+++ b/Source/web/ServiceWorkerGlobalScopeProxy.h

@@ -80,7 +80,7 @@ public:

virtual void dispatchSyncEvent(int) override;

// WorkerReportingProxy overrides:

- virtual void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL) override;

+ virtual void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL, int exceptionId) override;

virtual void reportConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) override;

virtual void postMessageToPageInspector(const String&) override;

virtual void postWorkerConsoleAgentEnabled() override { }

« no previous file with comments | « Source/core/workers/WorkerReportingProxy.h ('k') | Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | no next file with comments »