LayoutTests/inspector/console/worker-exception-message-contains-stack.html - Issue 743153002: [DevTools] Show stack trace for exceptions in dedicated workers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/inspector/console/worker-exception-message-contains-stack.html

Issue 743153002: [DevTools] Show stack trace for exceptions in dedicated workers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@worker-capture-stack

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/inspector/console/resources/worker-with-throw.js ('k') | LayoutTests/inspector/console/worker-exception-message-contains-stack-expected.txt » ('j') | Source/core/workers/WorkerGlobalScope.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

	4 <script src="../../http/tests/inspector/console-test.js"></script>

	5 <script>

	6 var worker;

	7

	8 function startWorker()

	9 {

	10 worker = new Worker("resources/worker-with-throw.js");

	11 }

	12

	13 function postMessageToWorker()

	14 {

	15 worker.postMessage();

	16 }

	17

	18 function test()

	19 {

	20 InspectorTest.addSniffer(WebInspector.RuntimeModel.prototype, "_executionCon textCreated", contextCreated);

	21 InspectorTest.evaluateInPage("startWorker()");

	22

	23 function contextCreated()

	24 {

	25 InspectorTest.changeExecutionContext("worker-with-throw.js");

	26 InspectorTest.evaluateInPage("postMessageToWorker()", step2);

	27 }

	28

	29 function step2()

	30 {

	31 InspectorTest.expandConsoleMessages(step3);
	vsevik 2014/12/01 15:06:02 I'd like to see both cases tested here: when the e I'd like to see both cases tested here: when the error is and is not handled in the main thread. Also, please make sure this test actually tests that the message was printed on the worker thread (or stack trace presence already proves that? I am not sure) kozy 2014/12/01 16:17:05 Done. And yes, stack trace with correct urls alrea Show quoted text On 2014/12/01 15:06:02, vsevik wrote: > I'd like to see both cases tested here: when the error is and is not handled in > the main thread. > Also, please make sure this test actually tests that the message was printed on > the worker thread (or stack trace presence already proves that? I am not sure) Done. And yes, stack trace with correct urls already proves correct message thread.
	32 }

	33

	34 function step3()

	35 {

	36 InspectorTest.dumpConsoleMessages();

	37 InspectorTest.completeTest();

	38 }

	39 };

	40 </script>

	41 </head>

	42 <body onload="runTest()">

	43 <p>Tests exception message from worker contains stack trace.</p>

	44 </body>

	45 </html>

OLD	NEW