Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 743123002: String for warning if only child accounts are present on Supervised account creation. (Closed)

Created:
6 years, 1 month ago by merkulova
Modified:
6 years ago
Reviewers:
Marc Treib, ygorshenin1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

String for warning if only child accounts are present on Supervised account creation. BUG=435064 Committed: https://crrev.com/c4b883a52b03da82ed577d6e385318344438a976 Cr-Commit-Position: refs/heads/master@{#308107}

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 2

Patch Set 3 : Rename. Decapitalization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (3 generated)
merkulova
6 years ago (2014-12-08 13:18:53 UTC) #2
Marc Treib
On 2014/12/08 13:18:53, merkulova wrote: Shouldn't you actually use the new string somewhere?
6 years ago (2014-12-08 13:21:36 UTC) #3
merkulova
It's already used at gaia_screen_handler
6 years ago (2014-12-08 13:22:38 UTC) #4
Marc Treib
On 2014/12/08 13:22:38, merkulova wrote: > It's already used at gaia_screen_handler Ah, then this just ...
6 years ago (2014-12-08 13:31:57 UTC) #5
merkulova
Rebased.
6 years ago (2014-12-08 13:45:56 UTC) #6
Marc Treib
On 2014/12/08 13:45:56, merkulova wrote: > Rebased. lgtm
6 years ago (2014-12-08 14:04:43 UTC) #7
Marc Treib
https://codereview.chromium.org/743123002/diff/20001/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/743123002/diff/20001/chrome/app/chromeos_strings.grdp#newcode1526 chrome/app/chromeos_strings.grdp:1526: <message name="IDS_CREATE_SUPERVISED_USER_NO_MANAGER_EXCEPT_SUPERVISED_TEXT" desc="Text shown when supervised user can be ...
6 years ago (2014-12-08 14:04:55 UTC) #8
merkulova
+ygorshenin@ https://codereview.chromium.org/743123002/diff/20001/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/743123002/diff/20001/chrome/app/chromeos_strings.grdp#newcode1526 chrome/app/chromeos_strings.grdp:1526: <message name="IDS_CREATE_SUPERVISED_USER_NO_MANAGER_EXCEPT_SUPERVISED_TEXT" desc="Text shown when supervised user can ...
6 years ago (2014-12-11 10:00:31 UTC) #10
ygorshenin1
lgtm
6 years ago (2014-12-12 14:43:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/743123002/40001
6 years ago (2014-12-12 16:11:59 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-12 17:12:26 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-12 17:13:16 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c4b883a52b03da82ed577d6e385318344438a976
Cr-Commit-Position: refs/heads/master@{#308107}

Powered by Google App Engine
This is Rietveld 408576698