Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 743013004: Move password manager automated tests to its own subdirectory (Closed)

Created:
6 years, 1 month ago by vabr (Chromium)
Modified:
6 years, 1 month ago
Reviewers:
Mike West
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move password manager automated tests to its own subdirectory Currently, the tests reside in //components/test/data/password_manager. Since that directory started to be used for actual test data, the automated test scripts should be separated in its own subdirectory. This CL creates automated_tests for the scripts, and moves them in that directory. BUG=369521 NOTRY=true Committed: https://crrev.com/625c7d5f043be651ad26fa15e7659b68204fbfe0 Cr-Commit-Position: refs/heads/master@{#305006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-6 lines, -1589 lines) Patch
D components/test/data/password_manager/README View 1 chunk +0 lines, -179 lines 0 comments Download
D components/test/data/password_manager/__init__.py View 1 chunk +0 lines, -6 lines 0 comments Download
A + components/test/data/password_manager/automated_tests/README View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/password_manager/automated_tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/password_manager/automated_tests/environment.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/password_manager/automated_tests/run_tests.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/password_manager/automated_tests/tests.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/password_manager/automated_tests/websitetest.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D components/test/data/password_manager/environment.py View 1 chunk +0 lines, -409 lines 0 comments Download
D components/test/data/password_manager/run_tests.py View 1 chunk +0 lines, -100 lines 0 comments Download
D components/test/data/password_manager/tests.py View 1 chunk +0 lines, -489 lines 0 comments Download
D components/test/data/password_manager/websitetest.py View 1 chunk +0 lines, -412 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vabr (Chromium)
Hi Mike, This is plain moving of files. PTAL. Cheers, Vaclav
6 years, 1 month ago (2014-11-20 13:18:33 UTC) #2
vabr (Chromium)
Also, I intend to skip tryjobs, because these scripts are not participating in any tests ...
6 years, 1 month ago (2014-11-20 13:19:21 UTC) #3
Mike West
LGTM.
6 years, 1 month ago (2014-11-20 13:24:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/743013004/1
6 years, 1 month ago (2014-11-20 13:28:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 13:28:45 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 13:29:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/625c7d5f043be651ad26fa15e7659b68204fbfe0
Cr-Commit-Position: refs/heads/master@{#305006}

Powered by Google App Engine
This is Rietveld 408576698