Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(126)

Issue 742963002: Rename String.prototype.contains to 'includes'. (Closed)

Created:
4 years, 7 months ago by Dmitry Lomov (no reviews)
Modified:
4 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Disable test262-es6 tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -175 lines) Patch
M src/harmony-string.js View 2 chunks +4 lines, -4 lines 0 comments Download
M test/js-perf-test/Strings/harmony-string.js View 2 chunks +5 lines, -5 lines 0 comments Download
D test/mjsunit/harmony/string-contains.js View 1 chunk +0 lines, -166 lines 0 comments Download
A test/mjsunit/harmony/string-includes.js View 1 chunk +166 lines, -0 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Dmitry Lomov (no reviews)
PTAL
4 years, 7 months ago (2014-11-19 23:42:48 UTC) #1
arv (Not doing code reviews)
LGTM Making things work on the real web is hard.
4 years, 7 months ago (2014-11-19 23:57:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742963002/1
4 years, 7 months ago (2014-11-20 00:04:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2014-11-20 00:32:07 UTC) #5
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/745543002/ by machenbach@chromium.org. ...
4 years, 7 months ago (2014-11-20 09:03:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742963002/20001
4 years, 7 months ago (2014-11-20 18:48:19 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2014-11-20 19:19:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698