Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: media/mojo/services/mojo_renderer_impl.h

Issue 742943002: Make MojoRendererImpl variable naming more generic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/mojo/services/mojo_renderer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_renderer_impl.h
diff --git a/media/mojo/services/mojo_renderer_impl.h b/media/mojo/services/mojo_renderer_impl.h
index 4b033d8013dbd4f3b0b0a44a9634ee783a3a999f..7c0f9c6899f28e9c9247f5c61b23459f5039b160 100644
--- a/media/mojo/services/mojo_renderer_impl.h
+++ b/media/mojo/services/mojo_renderer_impl.h
@@ -27,16 +27,14 @@ class DemuxerStreamProvider;
//
// MojoRendererImpl implements media::Renderer for use as either an audio
// or video renderer.
-//
-// TODO(tim): Only audio is currently supported. http://crbug.com/410451.
class MojoRendererImpl : public Renderer, public mojo::MediaRendererClient {
public:
// |task_runner| is the TaskRunner on which all methods are invoked.
- // |audio_renderer_provider| is a ServiceProvider from a connected
+ // |media_renderer_provider| is a ServiceProvider from a connected
// Application that is hosting a mojo::MediaRenderer.
MojoRendererImpl(
const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
- mojo::ServiceProvider* audio_renderer_provider);
+ mojo::ServiceProvider* media_renderer_provider);
~MojoRendererImpl() override;
// Renderer implementation.
@@ -63,17 +61,17 @@ class MojoRendererImpl : public Renderer, public mojo::MediaRendererClient {
void OnError() override;
private:
- // Called when |remote_audio_renderer_| has finished initializing.
+ // Called when |remote_media_renderer_| has finished initializing.
void OnInitialized();
// Task runner used to execute pipeline tasks.
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
DemuxerStreamProvider* demuxer_stream_provider_;
- mojo::MediaRendererPtr remote_audio_renderer_;
+ mojo::MediaRendererPtr remote_media_renderer_;
// Callbacks passed to Initialize() that we forward messages from
- // |remote_audio_renderer_| through.
+ // |remote_media_renderer_| through.
base::Closure init_cb_;
base::Closure ended_cb_;
PipelineStatusCB error_cb_;
« no previous file with comments | « no previous file | media/mojo/services/mojo_renderer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698