Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 742943002: Make MojoRendererImpl variable naming more generic. (Closed)

Created:
6 years, 1 month ago by xhwang
Modified:
6 years, 1 month ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make MojoRendererImpl variable naming more generic. Currently we support both audio and video. Updated some names and comments to better reflect this. BUG=410451 TEST=Naming and comment change only. R=dalecurtis@chromium.org Committed: https://crrev.com/9cf6007161c62bf9686538843de4c8d502fbbe23 Cr-Commit-Position: refs/heads/master@{#304939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M media/mojo/services/mojo_renderer_impl.h View 2 chunks +5 lines, -7 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 5 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
xhwang
PTAL
6 years, 1 month ago (2014-11-19 22:46:11 UTC) #1
DaleCurtis
lgtm
6 years, 1 month ago (2014-11-19 23:30:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742943002/1
6 years, 1 month ago (2014-11-19 23:37:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 00:21:38 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 00:22:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cf6007161c62bf9686538843de4c8d502fbbe23
Cr-Commit-Position: refs/heads/master@{#304939}

Powered by Google App Engine
This is Rietveld 408576698