sdk/lib/_internal/compiler/js_lib/native_helper.dart - Issue 742873002: Isolates: allow sending of arbitrary objects in dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/js_lib/native_helper.dart

Issue 742873002: Isolates: allow sending of arbitrary objects in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments and map-serialization fix. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/js_lib/isolate_serialization.dart ('K') | « sdk/lib/_internal/compiler/js_lib/js_helper.dart ('k') | sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/js_lib/native_helper.dart

diff --git a/sdk/lib/_internal/compiler/js_lib/native_helper.dart b/sdk/lib/_internal/compiler/js_lib/native_helper.dart

index 7de3c6fb634a4f0fa29faa7f89138f08ca17cbb9..798bf02f61dc93e9580ff9f29fa294718ea72fb3 100644

--- a/sdk/lib/_internal/compiler/js_lib/native_helper.dart

+++ b/sdk/lib/_internal/compiler/js_lib/native_helper.dart

@@ -443,7 +443,8 @@ applyHooksTransformer(transformer, hooks) {

const _baseHooks = const JS_CONST(r'''

function() {

function typeNameInChrome(o) {

- var name = o.constructor.name;

+ var constructor = o.constructor;

+ if (constructor) var name = constructor.name;

sra1 2014/11/24 18:18:06 While valid and compact JavaScript, this looks a l

floitsch 2014/11/25 12:32:18 Done.

if (name) return name;

var s = Object.prototype.toString.call(o);

return s.substring(8, s.length - 1);