sdk/lib/internal/internal.dart - Issue 742873002: Isolates: allow sending of arbitrary objects in dart2js.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sdk/lib/internal/internal.dart

Issue 742873002: Isolates: allow sending of arbitrary objects in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove unnecessary comment. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« sdk/lib/_internal/compiler/js_lib/isolate_serialization.dart ('K') | « sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart ('k') | tests/isolate/function_send_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 library dart._internal;	5 library dart._internal;

6	6

7 import 'dart:collection';	7 import 'dart:collection';

8	8

9 import 'dart:core' hide Symbol;	9 import 'dart:core' hide Symbol;

10 import 'dart:core' as core;	10 import 'dart:core' as core;

(...skipping 27 matching lines...) Expand all Loading...
38 100000000000000.0,	38 100000000000000.0,

39 1000000000000000.0, /* 15 */	39 1000000000000000.0, /* 15 */

40 10000000000000000.0,	40 10000000000000000.0,

41 100000000000000000.0,	41 100000000000000000.0,

42 1000000000000000000.0,	42 1000000000000000000.0,

43 10000000000000000000.0,	43 10000000000000000000.0,

44 100000000000000000000.0, /* 20 */	44 100000000000000000000.0, /* 20 */

45 1000000000000000000000.0,	45 1000000000000000000000.0,

46 10000000000000000000000.0,	46 10000000000000000000000.0,

47 ];	47 ];

	48

	49

	50 /// Marks the internal map in dart2js, so that internal libraries can is-check

	51 // them.

	52 abstract class InternalMap {

	53 }
	Lasse Reichstein Nielsen 2014/11/24 12:55:42 This should be in a dart2js specific import like _ This should be in a dart2js specific import like _isolate_helper, not in _internal which is also imported by the VM. (My argument for that is somewhat lessened by the table above only being used by the VM) floitsch 2014/11/24 15:06:57 moved to js_helper. Show quoted text On 2014/11/24 12:55:42, Lasse Reichstein Nielsen wrote: > This should be in a dart2js specific import like _isolate_helper, not in > _internal which is also imported by the VM. > > (My argument for that is somewhat lessened by the table above only being used by > the VM) moved to js_helper.
OLD	NEW