Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: tests/GLProgramsTest.cpp

Issue 742853002: Don't use NULL GrOptDrawState to indicate that draw should be skipped. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/gpu/GrOptDrawState.cpp ('K') | « src/gpu/GrOptDrawState.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/GLProgramsTest.cpp
diff --git a/tests/GLProgramsTest.cpp b/tests/GLProgramsTest.cpp
index 83b51d6f6689c27c574e64dfbef6ad8029b9ba97..dd11d506ead8168932e404c2785b6b2e2bd9d0e8 100644
--- a/tests/GLProgramsTest.cpp
+++ b/tests/GLProgramsTest.cpp
@@ -468,11 +468,8 @@ bool GrDrawTarget::programUnitTest(int maxStages) {
// create optimized draw state, setup readDst texture if required, and build a descriptor
// and program. ODS creation can fail, so we have to check
- SkAutoTUnref<GrOptDrawState> ods(GrOptDrawState::Create(ds,
- gpu,
- scissor,
- &dstCopy,
- drawType));
+ SkAutoTUnref<GrOptDrawState> ods
+ SkNEW_ARGS(GrOptDrawState, (ds, gpu, scissor, &dstCopy, drawType));
if (!ods.get()) {
egdaniel 2014/11/19 21:07:11 check skip here
bsalomon 2014/11/20 15:00:30 Done.
continue;
}
« src/gpu/GrOptDrawState.cpp ('K') | « src/gpu/GrOptDrawState.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698