Don't use NULL GrOptDrawState to indicate that draw should be skipped.

Don't use NULL GrOptDrawState to indicate that draw should be skipped.

Committed: https://skia.googlesource.com/skia/+/b03c4a35bd319d883925a39871b4972ff1b2c0cc

[bsalomon, 2014-11-19 20:44:36]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2014-11-19 21:07:12]

https://codereview.chromium.org/742853002/diff/1/src/gpu/GrOptDrawState.cpp
File src/gpu/GrOptDrawState.cpp (right):

https://codereview.chromium.org/742853002/diff/1/src/gpu/GrOptDrawState.cpp#n...
src/gpu/GrOptDrawState.cpp:44:
fRenderTarget.reset(drawState.fRenderTarget.get());
is worth having SkASSERT(ds.fRT.get())? Mostly thinking since we are using this
as a trigger for skipping.

https://codereview.chromium.org/742853002/diff/1/tests/GLProgramsTest.cpp
File tests/GLProgramsTest.cpp (right):

https://codereview.chromium.org/742853002/diff/1/tests/GLProgramsTest.cpp#new...
tests/GLProgramsTest.cpp:473: if (!ods.get()) {
check skip here

[bsalomon, 2014-11-20 15:00:30]

https://codereview.chromium.org/742853002/diff/1/src/gpu/GrOptDrawState.cpp
File src/gpu/GrOptDrawState.cpp (right):

https://codereview.chromium.org/742853002/diff/1/src/gpu/GrOptDrawState.cpp#n...
src/gpu/GrOptDrawState.cpp:44:
fRenderTarget.reset(drawState.fRenderTarget.get());
On 2014/11/19 21:07:11, egdaniel wrote:
> is worth having SkASSERT(ds.fRT.get())? Mostly thinking since we are using
this
> as a trigger for skipping.

Done.

https://codereview.chromium.org/742853002/diff/1/tests/GLProgramsTest.cpp
File tests/GLProgramsTest.cpp (right):

https://codereview.chromium.org/742853002/diff/1/tests/GLProgramsTest.cpp#new...
tests/GLProgramsTest.cpp:473: if (!ods.get()) {
On 2014/11/19 21:07:11, egdaniel wrote:
> check skip here

Done.

[egdaniel, 2014-11-20 15:45:19]

lgtm with question on assert

https://codereview.chromium.org/742853002/diff/40001/src/gpu/GrOptDrawState.cpp
File src/gpu/GrOptDrawState.cpp (right):

https://codereview.chromium.org/742853002/diff/40001/src/gpu/GrOptDrawState.c...
src/gpu/GrOptDrawState.cpp:45: SkASSERT(fRenderTarget);
Will just checking fRenderTarget do what we want? Do we not need
fRenderTarget.get()

[bsalomon, 2014-11-20 15:46:48]

https://codereview.chromium.org/742853002/diff/40001/src/gpu/GrOptDrawState.cpp
File src/gpu/GrOptDrawState.cpp (right):

https://codereview.chromium.org/742853002/diff/40001/src/gpu/GrOptDrawState.c...
src/gpu/GrOptDrawState.cpp:45: SkASSERT(fRenderTarget);
On 2014/11/20 15:45:19, egdaniel wrote:
> Will just checking fRenderTarget do what we want? Do we not need
> fRenderTarget.get()

yup, has a bool cast operator.

[bsalomon, 2014-11-20 15:46:51]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-11-20 15:47:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/742853002/40001

[commit-bot: I haz the power, 2014-11-20 15:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-20 15:48:18]

Try jobs failed on following builders:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Cl...)

[bsalomon, 2014-11-20 17:43:24]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-11-20 17:44:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/742853002/60001

[commit-bot: I haz the power, 2014-11-20 17:56:16]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/b03c4a35bd319d883925a39871b4972ff1b2c0cc