Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 74283003: [Telemetry] Make prebuilt binary installation a little more robust. (Closed)

Created:
7 years, 1 month ago by tonyg
Modified:
7 years, 1 month ago
Reviewers:
bulach, Philippe
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Make prebuilt binary installation a little more robust. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235816

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -42 lines) Patch
M tools/telemetry/bin/prebuilt/android/purge_ashmem.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/adb_commands.py View 1 2 3 3 chunks +29 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 2 3 2 chunks +10 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/unittest/system_stub.py View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
tonyg
7 years, 1 month ago (2013-11-15 20:39:05 UTC) #1
bulach
lgtm, nice!
7 years, 1 month ago (2013-11-18 10:58:29 UTC) #2
Philippe
lgtm, thanks Tony and sorry for any inconvenience I would have caused! https://codereview.chromium.org/74283003/diff/40001/tools/telemetry/bin/prebuilt/android/purge_ashmem.sha1 File tools/telemetry/bin/prebuilt/android/purge_ashmem.sha1 ...
7 years, 1 month ago (2013-11-18 13:53:01 UTC) #3
tonyg
On 2013/11/18 13:53:01, Philippe wrote: > lgtm, thanks Tony and sorry for any inconvenience I ...
7 years, 1 month ago (2013-11-18 15:33:29 UTC) #4
Philippe
On 2013/11/18 15:33:29, tonyg wrote: > On 2013/11/18 13:53:01, Philippe wrote: > > lgtm, thanks ...
7 years, 1 month ago (2013-11-18 15:35:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/74283003/40001
7 years, 1 month ago (2013-11-18 15:35:35 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=189613
7 years, 1 month ago (2013-11-18 16:12:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/74283003/300001
7 years, 1 month ago (2013-11-18 17:33:04 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 21:19:54 UTC) #9
Message was sent while issue was closed.
Change committed as 235816

Powered by Google App Engine
This is Rietveld 408576698