Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 742783008: AXRequired should be exposed only when aria-required="true" or required attribute is present (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

AXRequired should be exposed only when aria-required="true" or required attribute is present. BUG=none Committed: https://crrev.com/ef8183177b9be23c032c414d13f3bbb2a8bf3463 Cr-Commit-Position: refs/heads/master@{#307175}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixing nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 chunks +5 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria-required-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks!!
6 years ago (2014-12-05 10:10:38 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/742783008/diff/1/content/browser/accessibility/browser_accessibility_cocoa.mm File content/browser/accessibility/browser_accessibility_cocoa.mm (right): https://codereview.chromium.org/742783008/diff/1/content/browser/accessibility/browser_accessibility_cocoa.mm#newcode1353 content/browser/accessibility/browser_accessibility_cocoa.mm:1353: if (GetState(browserAccessibility_, ui::AX_STATE_REQUIRED)) nit: need { } around ...
6 years ago (2014-12-06 07:58:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742783008/20001
6 years ago (2014-12-06 12:35:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-06 13:15:24 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-06 13:16:01 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef8183177b9be23c032c414d13f3bbb2a8bf3463
Cr-Commit-Position: refs/heads/master@{#307175}

Powered by Google App Engine
This is Rietveld 408576698