Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 742783005: clang: Suppress a new warning in sqlite. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
CC:
chromium-reviews, Scott Hess - ex-Googler
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

clang: Suppress a new warning in sqlite. The warning has been fixed in sqlite upstream 3 years ago, but apparently we haven't updated sqlite to a version that has this 3 year old commit. BUG=340757, 82385 R=shess@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/8023dc8858dc8f0476277a45d73a26c79abcd195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/sqlite/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
michaeln: shess is on leave, so I guess you get to review sqlite stuff :-)
6 years, 1 month ago (2014-11-19 23:53:39 UTC) #2
Scott Hess - ex-Googler
LGTM, could you loop in bug 340757 so that when I come back and finish ...
6 years, 1 month ago (2014-11-20 00:50:29 UTC) #4
Nico
On 2014/11/20 00:50:29, Scott Hess - On Leave wrote: > LGTM, could you loop in ...
6 years, 1 month ago (2014-11-20 00:54:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742783005/1
6 years, 1 month ago (2014-11-20 00:55:47 UTC) #7
Nico
Committed patchset #1 (id:1) manually as 8023dc8858dc8f0476277a45d73a26c79abcd195 (presubmit successful).
6 years, 1 month ago (2014-11-20 00:57:42 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 00:57:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8023dc8858dc8f0476277a45d73a26c79abcd195
Cr-Commit-Position: refs/heads/master@{#304947}

Powered by Google App Engine
This is Rietveld 408576698