|
|
Created:
7 years, 1 month ago by M-A Ruel Modified:
7 years ago Reviewers:
iannucci CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org Visibility:
Public. |
DescriptionAdd a Yo Dawg to wake up folks.
Some people just don't want to read chromium-dev@. Wake them up.
R=iannucci@chromium.org
BUG=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=235548
Patch Set 1 #
Total comments: 2
Messages
Total messages: 11 (0 generated)
https://codereview.chromium.org/74273002/diff/1/git-try File git-try (right): https://codereview.chromium.org/74273002/diff/1/git-try#newcode14 git-try:14: echo '' Hm, aren't there some lingering legitimate uses for git try?
relatively speaking https://codereview.chromium.org/74273002/diff/1/git-try File git-try (right): https://codereview.chromium.org/74273002/diff/1/git-try#newcode14 git-try:14: echo '' On 2013/11/15 22:02:22, iannucci wrote: > Hm, aren't there some lingering legitimate uses for git try? Yes but not many.
On 2013/11/15 22:06:15, M-A Ruel wrote: > relatively speaking > > https://codereview.chromium.org/74273002/diff/1/git-try > File git-try (right): > > https://codereview.chromium.org/74273002/diff/1/git-try#newcode14 > git-try:14: echo '' > On 2013/11/15 22:02:22, iannucci wrote: > > Hm, aren't there some lingering legitimate uses for git try? > > Yes but not many. Could we whitelist legitimate base urls maybe? Or blacklist known-silly uses (like single-repo patches to src or third_party/WebKit?)
> > On 2013/11/15 22:02:22, iannucci wrote: > > > Hm, aren't there some lingering legitimate uses for git try? > > > > Yes but not many. > > Could we whitelist legitimate base urls maybe? Or blacklist known-silly uses > (like single-repo patches to src or third_party/WebKit?) I can revert it after a month if this concerns you. It's really just outputting an additional string.
On 2013/11/15 22:21:12, M-A Ruel wrote: > > > On 2013/11/15 22:02:22, iannucci wrote: > > > > Hm, aren't there some lingering legitimate uses for git try? > > > > > > Yes but not many. > > > > Could we whitelist legitimate base urls maybe? Or blacklist known-silly uses > > (like single-repo patches to src or third_party/WebKit?) > > I can revert it after a month if this concerns you. It's really just outputting > an additional string. Yeah I know, I just don't want to falsely bug the legitimate users. lgtm. If someone complains I've got you on speed dial ;-P
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/74273002/1
Message was sent while issue was closed.
Change committed as 235548
Message was sent while issue was closed.
I sympathize with wanting to move people over to git cl try, however the legitimate uses of git try make this message confusing for those groups and ends up adding noise for them. We should revert this until there is a better solution to pursue.
Message was sent while issue was closed.
On 2013/11/26 17:53:26, cmp wrote: > I sympathize with wanting to move people over to git cl try, however the > legitimate uses of git try make this message confusing for those groups and ends > up adding noise for them. We should revert this until there is a better > solution to pursue. I was planning to revert this next week.
Message was sent while issue was closed.
On 2013/11/26 17:54:33, M-A Ruel wrote: > On 2013/11/26 17:53:26, cmp wrote: > > I sympathize with wanting to move people over to git cl try, however the > > legitimate uses of git try make this message confusing for those groups and > ends > > up adding noise for them. We should revert this until there is a better > > solution to pursue. > > I was planning to revert this next week. Yeah, it's a bit confusing for, e.g. people working on gyp. I guess alternatively having "git cl try" work everywhere would be a good fix. :) |