Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 74273002: Add a Yo Dawg to wake up folks. (Closed)

Created:
7 years, 1 month ago by M-A Ruel
Modified:
7 years ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add a Yo Dawg to wake up folks. Some people just don't want to read chromium-dev@. Wake them up. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=235548

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M git-try View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (0 generated)
M-A Ruel
7 years, 1 month ago (2013-11-15 19:20:19 UTC) #1
iannucci
https://codereview.chromium.org/74273002/diff/1/git-try File git-try (right): https://codereview.chromium.org/74273002/diff/1/git-try#newcode14 git-try:14: echo '' Hm, aren't there some lingering legitimate uses ...
7 years, 1 month ago (2013-11-15 22:02:22 UTC) #2
M-A Ruel
relatively speaking https://codereview.chromium.org/74273002/diff/1/git-try File git-try (right): https://codereview.chromium.org/74273002/diff/1/git-try#newcode14 git-try:14: echo '' On 2013/11/15 22:02:22, iannucci wrote: ...
7 years, 1 month ago (2013-11-15 22:06:15 UTC) #3
iannucci
On 2013/11/15 22:06:15, M-A Ruel wrote: > relatively speaking > > https://codereview.chromium.org/74273002/diff/1/git-try > File git-try ...
7 years, 1 month ago (2013-11-15 22:10:43 UTC) #4
M-A Ruel
> > On 2013/11/15 22:02:22, iannucci wrote: > > > Hm, aren't there some lingering ...
7 years, 1 month ago (2013-11-15 22:21:12 UTC) #5
iannucci
On 2013/11/15 22:21:12, M-A Ruel wrote: > > > On 2013/11/15 22:02:22, iannucci wrote: > ...
7 years, 1 month ago (2013-11-15 22:25:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/74273002/1
7 years, 1 month ago (2013-11-17 20:12:42 UTC) #7
commit-bot: I haz the power
Change committed as 235548
7 years, 1 month ago (2013-11-17 20:14:17 UTC) #8
cmp
I sympathize with wanting to move people over to git cl try, however the legitimate ...
7 years ago (2013-11-26 17:53:26 UTC) #9
M-A Ruel
On 2013/11/26 17:53:26, cmp wrote: > I sympathize with wanting to move people over to ...
7 years ago (2013-11-26 17:54:33 UTC) #10
scottmg
7 years ago (2013-11-26 23:27:34 UTC) #11
Message was sent while issue was closed.
On 2013/11/26 17:54:33, M-A Ruel wrote:
> On 2013/11/26 17:53:26, cmp wrote:
> > I sympathize with wanting to move people over to git cl try, however the
> > legitimate uses of git try make this message confusing for those groups and
> ends
> > up adding noise for them.  We should revert this until there is a better
> > solution to pursue.
> 
> I was planning to revert this next week.

Yeah, it's a bit confusing for, e.g. people working on gyp. I guess
alternatively having "git cl try" work everywhere would be a good fix. :)

Powered by Google App Engine
This is Rietveld 408576698