Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 742523002: Browser watcher part three. (Closed)

Created:
6 years, 1 month ago by Sigurður Ásgeirsson
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@watcher_client
Project:
chromium
Visibility:
Public.

Description

Browser watcher part three. Implementation of the metrics provider and its tests. The metrics reporter reports the data captured by the watcher, communicating through through registry. See https://codereview.chromium.org/717223002/ for full change. BUG=412384 Committed: https://crrev.com/ce04138298b8564e8027c98aee0b28a766ec76da Cr-Commit-Position: refs/heads/master@{#304819}

Patch Set 1 #

Total comments: 22

Patch Set 2 : Address Erik's comments, rebase to CL 743463002. #

Patch Set 3 : Work around wonky RegKey API. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -0 lines) Patch
M components/browser_watcher.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A components/browser_watcher/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A components/browser_watcher/watcher_metrics_provider_win.h View 1 chunk +35 lines, -0 lines 0 comments Download
A components/browser_watcher/watcher_metrics_provider_win.cc View 1 2 1 chunk +118 lines, -0 lines 0 comments Download
A components/browser_watcher/watcher_metrics_provider_win_unittest.cc View 1 1 chunk +106 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
Sigurður Ásgeirsson
PTAL
6 years, 1 month ago (2014-11-18 20:45:11 UTC) #1
Sigurður Ásgeirsson
PTAL
6 years, 1 month ago (2014-11-18 20:45:40 UTC) #3
erikwright (departed)
https://codereview.chromium.org/742523002/diff/1/components/browser_watcher/watcher_metrics_provider_win.cc File components/browser_watcher/watcher_metrics_provider_win.cc (right): https://codereview.chromium.org/742523002/diff/1/components/browser_watcher/watcher_metrics_provider_win.cc#newcode29 components/browser_watcher/watcher_metrics_provider_win.cc:29: int pid = 0; this CL and the other ...
6 years, 1 month ago (2014-11-18 21:13:36 UTC) #4
Sigurður Ásgeirsson
thanks - another look? https://codereview.chromium.org/742523002/diff/1/components/browser_watcher/watcher_metrics_provider_win.cc File components/browser_watcher/watcher_metrics_provider_win.cc (right): https://codereview.chromium.org/742523002/diff/1/components/browser_watcher/watcher_metrics_provider_win.cc#newcode29 components/browser_watcher/watcher_metrics_provider_win.cc:29: int pid = 0; On ...
6 years, 1 month ago (2014-11-18 21:52:37 UTC) #5
erikwright (departed)
LGTM On 18 Nov 2014 16:52, <siggi@chromium.org> wrote: > thanks - another look? > > ...
6 years, 1 month ago (2014-11-18 22:32:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742523002/20001
6 years, 1 month ago (2014-11-18 23:20:02 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-18 23:20:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742523002/20001
6 years, 1 month ago (2014-11-18 23:46:30 UTC) #12
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-18 23:46:36 UTC) #14
erikwright (departed)
On 2014/11/18 23:46:36, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 1 month ago (2014-11-19 05:18:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742523002/20001
6 years, 1 month ago (2014-11-19 05:20:29 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/13331)
6 years, 1 month ago (2014-11-19 05:55:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742523002/40001
6 years, 1 month ago (2014-11-19 15:18:35 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-19 16:05:03 UTC) #22
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 16:05:52 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ce04138298b8564e8027c98aee0b28a766ec76da
Cr-Commit-Position: refs/heads/master@{#304819}

Powered by Google App Engine
This is Rietveld 408576698