Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc

Issue 742513006: Add ManagementMode enum and GetManagementMode(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
diff --git a/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc b/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
index a63cf76a1982a79255fe2361f228dedbcb62e7d7..4fe0c5d371e40ad4a022f6c958376e93ac1e9167 100644
--- a/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
+++ b/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
@@ -22,14 +22,11 @@
#include "chrome/common/chrome_content_client.h"
#include "chrome/common/pref_names.h"
#include "chromeos/system/statistics_provider.h"
-#include "components/policy/core/common/cloud/cloud_policy_constants.h"
#include "components/policy/core/common/cloud/cloud_policy_core.h"
#include "components/policy/core/common/cloud/device_management_service.h"
#include "components/policy/core/common/cloud/system_policy_request_context.h"
#include "net/url_request/url_request_context_getter.h"
-namespace em = enterprise_management;
-
namespace policy {
namespace {
@@ -105,7 +102,7 @@ void DeviceCloudPolicyInitializer::Shutdown() {
}
void DeviceCloudPolicyInitializer::StartEnrollment(
- em::PolicyData::ManagementMode management_mode,
+ ManagementMode management_mode,
DeviceManagementService* device_management_service,
const std::string& auth_token,
bool is_auto_enrollment,
@@ -226,21 +223,23 @@ scoped_ptr<CloudPolicyClient> DeviceCloudPolicyInitializer::CreateClient(
}
void DeviceCloudPolicyInitializer::TryToCreateClient() {
- if (device_store_->is_initialized() &&
- device_store_->has_policy() &&
- !device_store_->policy()->request_token().empty() &&
- !state_keys_broker_->pending() &&
- !enrollment_handler_) {
- DeviceManagementService* service = NULL;
- if (device_store_->policy()->management_mode() ==
- em::PolicyData::CONSUMER_MANAGED) {
- service = consumer_service_;
- } else {
- service = enterprise_service_;
- }
- if (service)
- StartConnection(CreateClient(service));
+ if (!device_store_->is_initialized() ||
+ !device_store_->has_policy() ||
+ state_keys_broker_->pending() ||
+ enrollment_handler_) {
+ return;
+ }
+
+ DeviceManagementService* service = NULL;
bartfab (slow) 2014/11/28 13:56:53 Nit: s/NULL/nullptr/
davidyu 2014/11/29 01:50:13 Done.
+ if (GetManagementMode(*device_store_->policy()) == MANAGEMENT_MODE_CONSUMER) {
+ service = consumer_service_;
+ } else if (GetManagementMode(*device_store_->policy()) ==
+ MANAGEMENT_MODE_ENTERPRISE) {
+ service = enterprise_service_;
}
+
+ if (service)
+ StartConnection(CreateClient(service));
}
void DeviceCloudPolicyInitializer::StartConnection(

Powered by Google App Engine
This is Rietveld 408576698