Add ManagementMode enum and GetManagementMode().

components/policy/core/common/cloud/cloud_policy_constants.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_POLICY_CORE_COMMON_CLOUD_CLOUD_POLICY_CONSTANTS_H_
 #define COMPONENTS_POLICY_CORE_COMMON_CLOUD_CLOUD_POLICY_CONSTANTS_H_
 
 #include <string>
 #include <utility>
 
 #include "components/policy/policy_export.h"
 
+namespace enterprise_management {
+class PolicyData;
+}
+
 namespace policy {
 
 // Constants related to the device management protocol.
 namespace dm_protocol {
 
 // Name extern constants for URL query parameters.
 POLICY_EXPORT extern const char kParamAgent[];
 POLICY_EXPORT extern const char kParamAppType[];
 POLICY_EXPORT extern const char kParamDeviceID[];
 POLICY_EXPORT extern const char kParamDeviceType[];
@@ skipping 101 matching lines @@
 
 // A pair that combines a policy fetch type and entity ID.
 typedef std::pair<std::string, std::string> PolicyNamespaceKey;
 
 // Returns the Chrome user policy type to use. This allows overridding the
 // default user policy type on Android and iOS for testing purposes.
 // TODO(joaodasilva): remove this once the server is ready.
 // http://crbug.com/248527
 POLICY_EXPORT const char* GetChromeUserPolicyType();
 
+// An enum that indicates if a device that is local owned, enterprise-managed,

[Mattias Nissler (ping if slow), 2014/11/28 09:21:18]

suggestion: s/that is local owned,/has a local owner, is/

[bartfab (slow), 2014/11/28 13:56:54]

I think that naming will still be wrong. Consumer management does not preclude a
local owner. In fact, it requires it. It should be more something like:

* Enterprise ownership with remote management
* Consumer ownership with remote management
* Consumer ownership with local management only

The same goes for the constants, really.

[davidyu, 2014/11/29 01:50:13]

I think it's hard to have a precise name while keeping it short. We have some
comments in the protocol buffer. I added a reference here to that proto file so
that readers can find the comments if they want to know what each mode means.

[davidyu, 2014/11/29 01:50:13]

Done.

+// or consumer-managed.
+enum ManagementMode {
+  MANAGEMENT_MODE_LOCAL = 0,

[Mattias Nissler (ping if slow), 2014/11/28 09:21:18]

for consistency, can we rename this to MANAGEMENT_MODE_LOCAL_OWNER?

[davidyu, 2014/11/29 01:50:13]

Done.

+  MANAGEMENT_MODE_ENTERPRISE = 1,
+  MANAGEMENT_MODE_CONSUMER = 2,
+};
+
+// If |management_mode| is set in |policy_data|, it simply returns it. For

[bartfab (slow), 2014/11/28 13:56:53]

Nit: s/it/this method/

[davidyu, 2014/11/29 01:50:14]

Done.

+// legacy policy data which don't have |management_mode|, it checks if

[bartfab (slow), 2014/11/28 13:56:54]

Nit 1: s/policy data/|policy_data|/
Nit 2: s/don't/doesn't/
Nit 3: s/|management_mode|/|management_mode| set/
Nit 4: s/it/this method/

[davidyu, 2014/11/29 01:50:14]

Done.

+// |request_token| is set and returns a mode for backward-compatiblity.

[bartfab (slow), 2014/11/28 13:56:53]

Nit: This comment goes into a lot of detail but then falls short of explaining
the full logic. Either expand the comment to cover the full logic or shorten the
comment to not talk about it at all.

[davidyu, 2014/11/29 01:50:13]

Done.

+ManagementMode GetManagementMode(
+    const enterprise_management::PolicyData& policy_data);
+
 }  // namespace policy
 
 #endif  // COMPONENTS_POLICY_CORE_COMMON_CLOUD_CLOUD_POLICY_CONSTANTS_H_