chrome/browser/chromeos/policy/policy_util.h - Issue 742513006: Add ManagementMode enum and GetManagementMode().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/policy/policy_util.h

Issue 742513006: Add ManagementMode enum and GetManagementMode(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_CHROMEOS_POLICY_POLICY_UTIL_H_

	6 #define CHROME_BROWSER_CHROMEOS_POLICY_POLICY_UTIL_H_

	7

	8 #include "policy/proto/device_management_backend.pb.h"

	9

	10 namespace policy {

	11

	12 // If \|management_mode\| is set in \|policy_data\|, it simply returns it. For

	13 // legacy policy data which don't have \|management_mode\|, it checks if

	14 // \|request_token\| is set and returns a mode for backward-compatiblity.

	15 enterprise_management::PolicyData::ManagementMode

	16 GetManagementMode(const enterprise_management::PolicyData& policy_data);
	Mattias Nissler (ping if slow) 2014/11/27 08:37:31 Two suggestions: 1. I think moving this over to cl Two suggestions: 1. I think moving this over to cloud_policy_constants.h would be better. This isn't a constant of course, but that file already contains similar helpers, so people would look there I guess. 2. Using the fully-qualified ManagementMode type from the proto is rather unwieldy - how about putting an alias / copy in cloud_policy_constants, so I can just write MANAGEMENT_MODE_LOCAL_OWNER within the policy namespace? davidyu 2014/11/27 10:04:08 Ok. I added a new enum. I also refactored Enrollme Show quoted text On 2014/11/27 08:37:31, Mattias Nissler wrote: > Two suggestions: > 1. I think moving this over to cloud_policy_constants.h would be better. This > isn't a constant of course, but that file already contains similar helpers, so > people would look there I guess. > 2. Using the fully-qualified ManagementMode type from the proto is rather > unwieldy - how about putting an alias / copy in cloud_policy_constants, so I can > just write MANAGEMENT_MODE_LOCAL_OWNER within the policy namespace? Ok. I added a new enum. I also refactored EnrollmentHandlerChromeOS to use this new enum.
	17

	18 } // namespace policy

	19

	20 #endif // CHROME_BROWSER_CHROMEOS_POLICY_POLICY_UTIL_H_

OLD	NEW