Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 742483004: Clean up FreeType library ref counting. (Closed)

Created:
6 years ago by bungeman-skia
Modified:
6 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Clean up FreeType library ref counting. The existing reference counting and code for LCD is difficult to understand. This cleans it up a bit in preperation for the typefaces holding the references and faces themselves which will clean this up quite a bit more. Committed: https://skia.googlesource.com/skia/+/9dc24686e719566fd9ef054d6d27cff3a12daa71

Patch Set 1 #

Patch Set 2 : Line lengths. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -131 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 17 chunks +142 lines, -131 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bungeman-skia
This is a bit of a cleanup by itself, but the idea is to eventually ...
6 years ago (2014-12-01 21:28:19 UTC) #2
reed1
lgtm
6 years ago (2014-12-01 21:38:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742483004/20001
6 years ago (2014-12-01 21:51:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/9dc24686e719566fd9ef054d6d27cff3a12daa71
6 years ago (2014-12-01 22:01:37 UTC) #6
jcgregorio
6 years ago (2014-12-02 01:35:45 UTC) #7
Message was sent while issue was closed.
On 2014/12/01 22:01:37, I haz the power (commit-bot) wrote:
> Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/9dc24686e719566fd9ef054d6d27cff3a12daa71

Was this change expected to have a performance impact?

  https://skiaperf.com/cl/346

For example, one trace from that cluster:

  https://skiaperf.com/#1601

Powered by Google App Engine
This is Rietveld 408576698