[Chromoting] Break up the webapp's init function into smaller chunks.

[Chromoting] Break up the webapp's init function into smaller chunks.

BUG=

Committed: https://crrev.com/7b15ac05fa1e7be70ab1a8978d1c18b74610a677
Cr-Commit-Position: refs/heads/master@{#306336}

[garykac, 2014-11-18 19:08:15]

garykac@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[garykac, 2014-11-18 21:45:54]

https://codereview.chromium.org/742473002/diff/20001/remoting/webapp/crd/js/r...
File remoting/webapp/crd/js/remoting.js (left):

https://codereview.chromium.org/742473002/diff/20001/remoting/webapp/crd/js/r...
remoting/webapp/crd/js/remoting.js:26: function consentRequired_(authContinue) {
consentRequired moved into auth_init.js

https://codereview.chromium.org/742473002/diff/20001/remoting/webapp/crd/js/r...
remoting/webapp/crd/js/remoting.js:69: remoting.identity = new
remoting.Identity(consentRequired_);
identity is inited in auth_init

https://codereview.chromium.org/742473002/diff/20001/remoting/webapp/crd/js/r...
remoting/webapp/crd/js/remoting.js:71: remoting.windowFrame = new
remoting.WindowFrame(
windowFrame, optionsMenu and toolbar are crd-specific. moved into crd_init

[garykac, 2014-11-19 19:06:40]

PTAL

https://codereview.chromium.org/742473002/diff/100001/remoting/remoting_webap...
File remoting/remoting_webapp_files.gypi (right):

https://codereview.chromium.org/742473002/diff/100001/remoting/remoting_webap...
remoting/remoting_webapp_files.gypi:254: 'remoting_webapp_crd_js_files': [
This change effectively renames _all_js_files to _crd_js_files.

[Jamie, 2014-11-19 19:31:24]

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/base/js...
File remoting/webapp/base/js/auth_init.js (right):

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/base/js...
remoting/webapp/base/js/auth_init.js:14: remoting.oauth2 = new
remoting.OAuth2();
Do we need this global any more? Ideally, we should use remoting.identity
throughout, and fix any references to remoting.oauth2 (assuming they are
API-compatible).

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/base/js...
remoting/webapp/base/js/auth_init.js:60: function consentRequired_(authContinue)
{
Since you're refactoring, this should be called something like
remoting.promptForConsent, or even make a local function definition in
initIdentity.

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/crd_init.js (right):

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/crd_init.js:14: remoting.initCommon();
Can we come up with a better name for this?

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/remoting.js (right):

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/remoting.js:40: remoting.fullscreen = new
remoting.FullscreenAppsV2();
Is this needed for app-remoting as well as CRD?

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/remoting.js:60: remoting.initTesting_();
Remove underscore for consistency (or just get rid of the function; it's so
short it doesn't add much to readability IMO).

[garykac, 2014-11-20 03:18:50]

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/base/js...
File remoting/webapp/base/js/auth_init.js (right):

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/base/js...
remoting/webapp/base/js/auth_init.js:14: remoting.oauth2 = new
remoting.OAuth2();
On 2014/11/19 19:31:24, Jamie wrote:
> Do we need this global any more? Ideally, we should use remoting.identity
> throughout, and fix any references to remoting.oauth2 (assuming they are
> API-compatible).

I don't know if it is still required, but I don't think potentially-breaking
changes like that should be part of this cl. It's even less useful to make the
change since AppsV1 should be going away soon.

I'll add a TODO to follow-up on this.

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/base/js...
remoting/webapp/base/js/auth_init.js:60: function consentRequired_(authContinue)
{
On 2014/11/19 19:31:24, Jamie wrote:
> Since you're refactoring, this should be called something like
> remoting.promptForConsent, or even make a local function definition in
> initIdentity.

Done.

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/crd_init.js (right):

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/crd_init.js:14: remoting.initCommon();
On 2014/11/19 19:31:24, Jamie wrote:
> Can we come up with a better name for this?

Changed to initGlobalObjects(), which isn't much better...

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/remoting.js (right):

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/remoting.js:40: remoting.fullscreen = new
remoting.FullscreenAppsV2();
On 2014/11/19 19:31:24, Jamie wrote:
> Is this needed for app-remoting as well as CRD?

It's needed now, but I didn't track down exactly why. I think we clean up the
dependency and remove this in the future.

https://codereview.chromium.org/742473002/diff/100001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/remoting.js:60: remoting.initTesting_();
On 2014/11/19 19:31:24, Jamie wrote:
> Remove underscore for consistency (or just get rid of the function; it's so
> short it doesn't add much to readability IMO).

Done.  I was guessing that the testing init code might grow, but we can break it
out at that time if needed.

[Jamie, 2014-11-21 01:36:22]

lgtm

[garykac, 2014-12-01 18:53:37]

The CQ bit was checked by garykac@chromium.org

[commit-bot: I haz the power, 2014-12-01 18:54:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/742473002/120001

[commit-bot: I haz the power, 2014-12-01 19:57:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-01 19:57:30]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[garykac, 2014-12-02 02:10:39]

The CQ bit was checked by garykac@chromium.org

[commit-bot: I haz the power, 2014-12-02 02:11:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/742473002/140001

[commit-bot: I haz the power, 2014-12-02 03:12:43]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2014-12-02 03:14:15]

Patchset 8 (id:??) landed as
https://crrev.com/7b15ac05fa1e7be70ab1a8978d1c18b74610a677
Cr-Commit-Position: refs/heads/master@{#306336}