Issue 742433002: Use ZoneVector instead of ZoneList in the graph builder.

Issue 742433002: Use ZoneVector instead of ZoneList in the graph builder. (Closed)

Created:
6 years, 1 month ago by Michael Starzinger

Modified:
6 years, 1 month ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-operator-counts

Project:
v8

Visibility:
Public.

More Reviews

Description

Use ZoneVector instead of ZoneList in the graph builder. R=titzer@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/f8e51d0a14465afd56da0d08fa942f25b1e1c8e8

Patch Set 2 : Fix Win64 compilation. #

Total comments: 2

Patch Set 3 : Remove pesky space. #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -17 lines)			Patch
M	src/compiler/ast-graph-builder.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/compiler/ast-graph-builder.cc	View	1	4 chunks	+11 lines, -10 lines	0 comments	Download
M	src/compiler/control-builders.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/compiler/control-builders.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/parser.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

titzer

lgtm https://codereview.chromium.org/742433002/diff/20001/src/compiler/ast-graph-builder.h File src/compiler/ast-graph-builder.h (right): https://codereview.chromium.org/742433002/diff/20001/src/compiler/ast-graph-builder.h#newcode129 src/compiler/ast-graph-builder.h:129: ZoneVector<Handle<Object> > globals_; With C++ I think we ...

6 years, 1 month ago (2014-11-18 16:24:33 UTC) #2

Michael Starzinger

https://codereview.chromium.org/742433002/diff/20001/src/compiler/ast-graph-builder.h File src/compiler/ast-graph-builder.h (right): https://codereview.chromium.org/742433002/diff/20001/src/compiler/ast-graph-builder.h#newcode129 src/compiler/ast-graph-builder.h:129: ZoneVector<Handle<Object> > globals_; On 2014/11/18 16:24:33, titzer wrote: > ...

6 years, 1 month ago (2014-11-18 17:21:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742433002/40001

6 years, 1 month ago (2014-11-18 17:22:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages