Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 74243002: Use exec and proper quoting in top-level gyp command (Closed)

Created:
7 years, 1 month ago by Mark Mentovai
Modified:
7 years, 1 month ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Use exec and proper quoting in top-level gyp command. R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1787

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gyp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
7 years, 1 month ago (2013-11-15 19:13:28 UTC) #1
scottmg
lgtm
7 years, 1 month ago (2013-11-15 19:14:23 UTC) #2
Mark Mentovai
7 years, 1 month ago (2013-11-15 19:14:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698