Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 742373002: use (num_cores/2) jobs by default for telemetry unittests. (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

use (num_cores/2) jobs by default for telemetry unittests. Previously we were using (num_cores/4). Let's see if we can get more parallelism and still not overload the machine. R=dtu@chromium.org BUG=388256 Committed: https://crrev.com/4866abd7d1c6bfeb520ccd74ffb730ed45dd3cf3 Cr-Commit-Position: refs/heads/master@{#305163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/unittest_util/run_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
Dave, Tony, I'll let you decide if you want to land this or not, or ...
6 years, 1 month ago (2014-11-21 01:43:58 UTC) #2
tonyg
lgtm Let's see what happens.
6 years, 1 month ago (2014-11-21 01:47:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742373002/1
6 years, 1 month ago (2014-11-21 01:48:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 04:37:40 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4866abd7d1c6bfeb520ccd74ffb730ed45dd3cf3 Cr-Commit-Position: refs/heads/master@{#305163}
6 years, 1 month ago (2014-11-21 04:38:23 UTC) #7
Roger Tawa OOO till Jul 10th
6 years, 1 month ago (2014-11-21 17:28:48 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/748073003/ by rogerta@chromium.org.

The reason for reverting is: May be causing failures on XP Tests bot:
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(1)

First failure here:
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/build...

Speculative revert after discussions..

Powered by Google App Engine
This is Rietveld 408576698