Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 742353006: Revert of Optimize add/set/delete operations for string keys in Maps and Sets (Closed)

Created:
6 years ago by adamk
Modified:
6 years ago
CC:
v8-dev, rossberg, arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Revert of Optimize add/set/delete operations for string keys in Maps and Sets (patchset #1 id:1 of https://codereview.chromium.org/777663003/) Reason for revert: Deopt fuzzer reports that something's still broken, reverting until I can create a minimal repro. Original issue's description: > Optimize add/set/delete operations for string keys in Maps and Sets > > This was previously landed in commit 66e2f60, but failed the > collections mjsunit test with --deopt-every-n=1 due to a typo > in the shrinking code. This patch corrects and simplifies the > shrinking logic, and the tests now pass. > > R=dslomov@chromium.org > > Committed: https://chromium.googlesource.com/v8/v8/+/8599f5f047b4400f7f61de9e449b2246c9aad471 TBR=dslomov@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -367 lines) Patch
M src/collection.js View 4 chunks +4 lines, -4 lines 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -14 lines 0 comments Download
M src/hydrogen.cc View 5 chunks +38 lines, -334 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
Created Revert of Optimize add/set/delete operations for string keys in Maps and Sets
6 years ago (2014-12-05 22:24:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742353006/1
6 years ago (2014-12-05 22:24:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 22:25:08 UTC) #3
adamk
6 years ago (2014-12-05 22:31:13 UTC) #4
Message was sent while issue was closed.
Note: this time the failure was on ia32, but still reproduceable.

Powered by Google App Engine
This is Rietveld 408576698