Source/modules/accessibility/AXProgressIndicator.h - Issue 742353004: Implement computedRole and computedName (behind a flag)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXProgressIndicator.h

Issue 742353004: Implement computedRole and computedName (behind a flag) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Finished pulling out ScopedAXObjectCache etc. Many fprintfs remain. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/accessibility/AXObject.cpp ('K') | « Source/modules/accessibility/AXObjectCacheImpl.cpp ('k') | Source/modules/accessibility/AXProgressIndicator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXProgressIndicator.h

diff --git a/Source/modules/accessibility/AXProgressIndicator.h b/Source/modules/accessibility/AXProgressIndicator.h

index 140dbdb5785b7bd202a8dc71dad5a6f4b84869d7..5cff33c2cd9c2f1498c8ef624cc0a054095a85ca 100644

--- a/Source/modules/accessibility/AXProgressIndicator.h

+++ b/Source/modules/accessibility/AXProgressIndicator.h

@@ -25,12 +25,13 @@

namespace blink {

+class AXObjectCache;

class HTMLProgressElement;

class RenderProgress;

class AXProgressIndicator final : public AXRenderObject {

public:

- static PassRefPtr<AXProgressIndicator> create(RenderProgress*);

+ static PassRefPtr<AXProgressIndicator> create(RenderProgress*, AXObjectCache*);

private:

virtual AccessibilityRole roleValue() const override { return ProgressIndicatorRole; }

@@ -41,7 +42,7 @@ private:

virtual float maxValueForRange() const override;

virtual float minValueForRange() const override;

- explicit AXProgressIndicator(RenderProgress*);

+ AXProgressIndicator(RenderProgress*, AXObjectCache*);

HTMLProgressElement* element() const;

virtual bool computeAccessibilityIsIgnored() const override;