Source/modules/accessibility/AXMenuList.h - Issue 742353004: Implement computedRole and computedName (behind a flag)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXMenuList.h

Issue 742353004: Implement computedRole and computedName (behind a flag) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Finished pulling out ScopedAXObjectCache etc. Many fprintfs remain. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/Document.h ('K') | « Source/modules/accessibility/AXMediaControls.cpp ('k') | Source/modules/accessibility/AXMenuList.cpp » ('j') | Source/modules/accessibility/AXObject.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXMenuList.h

diff --git a/Source/modules/accessibility/AXMenuList.h b/Source/modules/accessibility/AXMenuList.h

index 83433fa33d721763449d3eaad0e93bee2c8874d8..a82d365f41cb7e1ca97c86ead0b0a86a290533e3 100644

--- a/Source/modules/accessibility/AXMenuList.h

+++ b/Source/modules/accessibility/AXMenuList.h

@@ -30,11 +30,12 @@

namespace blink {

+class AXObjectCache;

class RenderMenuList;

class AXMenuList final : public AXRenderObject {

public:

- static PassRefPtr<AXMenuList> create(RenderMenuList* renderer);

+ static PassRefPtr<AXMenuList> create(RenderMenuList* renderer, AXObjectCache*);

virtual bool isCollapsed() const override;

virtual AccessibilityExpanded isExpanded() const override final;

@@ -43,7 +44,7 @@ public:

void didUpdateActiveOption(int optionIndex);

private:

- explicit AXMenuList(RenderMenuList*);

+ AXMenuList(RenderMenuList*, AXObjectCache*);

virtual bool isMenuList() const override { return true; }

virtual AccessibilityRole roleValue() const override { return PopUpButtonRole; }