Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: Source/modules/accessibility/AXMediaControls.h

Issue 742353004: Implement computedRole and computedName (behind a flag) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Finished pulling out ScopedAXObjectCache etc. Many fprintfs remain. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXMediaControls.h
diff --git a/Source/modules/accessibility/AXMediaControls.h b/Source/modules/accessibility/AXMediaControls.h
index 51892d85a504c9e31baea4f8acd805b3cfe04cee..471744db0d5a2c243f010dddb951d925ebb58202 100644
--- a/Source/modules/accessibility/AXMediaControls.h
+++ b/Source/modules/accessibility/AXMediaControls.h
@@ -35,10 +35,12 @@
namespace blink {
+class AXObjectCache;
+
class AccessibilityMediaControl : public AXRenderObject {
public:
- static PassRefPtr<AXObject> create(RenderObject*);
+ static PassRefPtr<AXObject> create(RenderObject*, AXObjectCache*);
virtual ~AccessibilityMediaControl() { }
virtual AccessibilityRole roleValue() const override;
@@ -48,7 +50,7 @@ public:
virtual String helpText() const override;
protected:
- explicit AccessibilityMediaControl(RenderObject*);
+ AccessibilityMediaControl(RenderObject*, AXObjectCache*);
MediaControlElementType controlType() const;
virtual bool computeAccessibilityIsIgnored() const override;
};
@@ -57,7 +59,7 @@ protected:
class AccessibilityMediaTimeline final : public AXSlider {
public:
- static PassRefPtr<AXObject> create(RenderObject*);
+ static PassRefPtr<AXObject> create(RenderObject*, AXObjectCache*);
virtual ~AccessibilityMediaTimeline() { }
virtual String helpText() const override;
@@ -65,14 +67,14 @@ public:
const AtomicString& getAttribute(const QualifiedName& attribute) const;
private:
- explicit AccessibilityMediaTimeline(RenderObject*);
+ AccessibilityMediaTimeline(RenderObject*, AXObjectCache*);
};
class AXMediaControlsContainer final : public AccessibilityMediaControl {
public:
- static PassRefPtr<AXObject> create(RenderObject*);
+ static PassRefPtr<AXObject> create(RenderObject*, AXObjectCache*);
virtual ~AXMediaControlsContainer() { }
virtual AccessibilityRole roleValue() const override { return ToolbarRole; }
@@ -81,7 +83,7 @@ public:
virtual String accessibilityDescription() const override;
private:
- explicit AXMediaControlsContainer(RenderObject*);
+ AXMediaControlsContainer(RenderObject*, AXObjectCache*);
bool controllingVideoElement() const;
virtual bool computeAccessibilityIsIgnored() const override;
};
@@ -90,7 +92,7 @@ private:
class AccessibilityMediaTimeDisplay final : public AccessibilityMediaControl {
public:
- static PassRefPtr<AXObject> create(RenderObject*);
+ static PassRefPtr<AXObject> create(RenderObject*, AXObjectCache*);
virtual ~AccessibilityMediaTimeDisplay() { }
virtual AccessibilityRole roleValue() const override { return StaticTextRole; }
@@ -99,7 +101,7 @@ public:
virtual String accessibilityDescription() const override;
private:
- explicit AccessibilityMediaTimeDisplay(RenderObject*);
+ AccessibilityMediaTimeDisplay(RenderObject*, AXObjectCache*);
virtual bool computeAccessibilityIsIgnored() const override;
};

Powered by Google App Engine
This is Rietveld 408576698