Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 742353004: Implement computedRole and computedName (behind a flag) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Revert changes to core/testing Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXObjectCacheImpl.cpp
diff --git a/Source/modules/accessibility/AXObjectCacheImpl.cpp b/Source/modules/accessibility/AXObjectCacheImpl.cpp
index ab190e195d09f9c58ed60f5fc7aa43aeaeab8063..dd277299cf5894ef6f1935ee8370f21cb8d43abc 100644
--- a/Source/modules/accessibility/AXObjectCacheImpl.cpp
+++ b/Source/modules/accessibility/AXObjectCacheImpl.cpp
@@ -1074,6 +1074,24 @@ void AXObjectCacheImpl::handleScrollPositionChanged(RenderObject* renderObject)
postPlatformNotification(getOrCreate(renderObject), AXScrollPositionChanged);
}
+const AtomicString& AXObjectCacheImpl::computedRoleForNode(Node* node)
+{
+ AXObject* obj = getOrCreate(node);
+ if (!obj)
+ return AXObject::roleName(UnknownRole);
+ return AXObject::roleName(obj->roleValue());
+}
+
+String AXObjectCacheImpl::computedNameForNode(Node* node)
+{
+ AXObject* obj = getOrCreate(node);
+ if (!obj)
+ return "";
+
+ String description = obj->accessibilityDescription();
+ return description.isNull() ? obj->title() : description;
+}
+
void AXObjectCacheImpl::setCanvasObjectBounds(Element* element, const LayoutRect& rect)
{
AXObject* obj = getOrCreate(element);

Powered by Google App Engine
This is Rietveld 408576698