Implement computedRole and computedName (behind a flag)

Source/modules/accessibility/AXObjectCacheImpl.cpp

 /*
  * Copyright (C) 2014, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 1056 matching lines @@
     if (targetAXObject && !targetAXObject->children().isEmpty())
         targetAXObject = targetAXObject->children()[0].get();
     postPlatformNotification(targetAXObject, AXScrollPositionChanged);
 }
 
 void AXObjectCacheImpl::handleScrollPositionChanged(RenderObject* renderObject)
 {
     postPlatformNotification(getOrCreate(renderObject), AXScrollPositionChanged);
 }
 
+const AtomicString& AXObjectCacheImpl::computedRoleForNode(Node* node)
+{
+    AXObject* obj = getOrCreate(node);
+    if (!obj)
+        return AXObject::roleName(UnknownRole);
+    return AXObject::roleName(obj->roleValue());
+}
+
+String AXObjectCacheImpl::computedNameForNode(Node* node)

[dmazzoni, 2014/12/18 23:12:20]

The logic for this looks fine, but instead of putting it here, how about putting
it in AXObject? Call it computedName and add a comment saying that this should
do the official accessible name calculation, and should eventually replace
title().

[aboxhall, 2014/12/19 00:02:08]

Ok, done.

+{
+    AXObject* obj = getOrCreate(node);
+    if (!obj)
+        return "";
+
+    String title = obj->title();
+
+    String titleUIText;
+    if (title.isEmpty()) {
+        AXObject* titleUIElement = obj->titleUIElement();
+        if (titleUIElement) {
+            titleUIText = titleUIElement->textUnderElement();
+            if (!titleUIText.isEmpty())
+                return titleUIText;
+        }
+    }
+
+    String description = obj->accessibilityDescription();
+    if (!description.isEmpty())
+        return description;
+
+    if (!title.isEmpty())
+        return title;
+
+    String placeholder;

[dmazzoni, 2014/12/18 23:12:20]

The official accessible name calculation says that the placeholder attribute
overrides the title attribute - is it doing that correctly?

(Not AXObject::title, but the HTML attr "title", as in a tooltip.)

[aboxhall, 2014/12/19 00:02:08]

Yeah, it doesn't. I added a test case but I don't really want to fix the issue
in this change, as discussed.

+    if (isHTMLInputElement(node)) {
+        HTMLInputElement* element = toHTMLInputElement(node);
+        placeholder = element->strippedPlaceholder();
+        if (!placeholder.isEmpty())
+            return placeholder;
+    }
+
+    return String();
+}
+
 void AXObjectCacheImpl::setCanvasObjectBounds(Element* element, const LayoutRect& rect)
 {
     AXObject* obj = getOrCreate(element);
     if (!obj)
         return;
 
     obj->setElementRect(rect);
 }
 
 } // namespace blink