Issue 742183002: Enable ES6 classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 742183002: Enable ES6 classes. (Closed)

Created:
6 years, 1 month ago by esprehn

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium, eseidel

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Enable ES6 classes. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b34b90592e51aadf4e7daf9ae0f2b75fa7f6760a

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+186 lines, -11 lines)			Patch
M	sky/engine/bindings/core/v8/V8Initializer.cpp	View	2 chunks	+9 lines, -11 lines	1 comment	Download
A	sky/tests/js/classes.sky	View	1 chunk	+163 lines, -0 lines	0 comments	Download
A	sky/tests/js/classes-expected.txt	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

eseidel

https://codereview.chromium.org/742183002/diff/1/sky/engine/bindings/core/v8/V8Initializer.cpp File sky/engine/bindings/core/v8/V8Initializer.cpp (right): https://codereview.chromium.org/742183002/diff/1/sky/engine/bindings/core/v8/V8Initializer.cpp#newcode203 sky/engine/bindings/core/v8/V8Initializer.cpp:203: static const char v8Flags[] = "--harmony-classes"; We should turn ...

6 years, 1 month ago (2014-11-20 18:54:21 UTC) #4

esprehn

6 years, 1 month ago (2014-11-20 18:55:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b34b90592e51aadf4e7daf9ae0f2b75fa7f6760a.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages