Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 742133002: [MIPS] Add mips_fpu_mode to build/common.gypi (Closed)

Created:
6 years, 1 month ago by gordanac
Modified:
6 years, 1 month ago
Reviewers:
rmcilroy, gordanac
CC:
chromium-reviews, petar.jovanovic, petarj, Paul Lind
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[MIPS] Add mips_fpu_mode to build/common.gypi Gyp variable mips_fpu_mode is currenty used and needed by v8. BUG= TEST=call build/gyp_chromium with GYP_DEFINES="target_arch=mipsel mips_arch_variant=r2" Committed: https://crrev.com/aaea927b991d49de394f7482ca3ecfacdc9e3906 Cr-Commit-Position: refs/heads/master@{#305057}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing comment and adding target_arch check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/common.gypi View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
gordanac
Please take a look.
6 years, 1 month ago (2014-11-20 16:57:43 UTC) #2
rmcilroy
lgtm with a comment. https://codereview.chromium.org/742133002/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/742133002/diff/1/build/common.gypi#newcode2277 build/common.gypi:2277: ['mips_arch_variant=="r2" and android_webview_build==0', { nit ...
6 years, 1 month ago (2014-11-20 17:16:30 UTC) #3
gordanac
On 2014/11/20 17:16:30, rmcilroy wrote: > lgtm with a comment. > > https://codereview.chromium.org/742133002/diff/1/build/common.gypi > File ...
6 years, 1 month ago (2014-11-20 17:34:19 UTC) #4
rmcilroy
lgtm, thanks
6 years, 1 month ago (2014-11-20 17:38:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742133002/20001
6 years, 1 month ago (2014-11-20 18:12:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 19:13:06 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 19:13:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aaea927b991d49de394f7482ca3ecfacdc9e3906
Cr-Commit-Position: refs/heads/master@{#305057}

Powered by Google App Engine
This is Rietveld 408576698