Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: LayoutTests/fast/files/file-constructor.html

Issue 74213009: File constructor understands lastModified. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated to latest File API ED. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/files/file-constructor.html
diff --git a/LayoutTests/fast/files/file-constructor.html b/LayoutTests/fast/files/file-constructor.html
index f615864f75e496d559deab8828f0874b669cf0b7..61c979b27d90a9d5de9dee57506f8fafabdbaf40 100644
--- a/LayoutTests/fast/files/file-constructor.html
+++ b/LayoutTests/fast/files/file-constructor.html
@@ -87,6 +87,23 @@ shouldBe("(new File([], 'world.html', {type:'text/html'})).type", "'text/html'")
shouldBe("(new File([], 'world.html', {type:'text/html'})).size", "0");
shouldBe("(new File([], 'world.html', {type:'text/plain;charset=UTF-8'})).type", "'text/plain;charset=utf-8'");
+// Test that the lastModified is correctly added to the File.
+var aDate = new Date(441532800000);
+shouldBe("(new File([], 'world.html', {lastModified: 441532800000})).lastModified", "441532800000");
+// Unless specified, lastModifiedDate should default to now.
kinuko 2013/11/20 08:01:22 nit: lastModifiedDate -> lastModified
pwnall-personal 2013/11/20 09:51:07 Done. Thank you!
+var startTime = Date.now();
+var fileTime = (new File([], 'world.html')).lastModified;
+var endTime = Date.now();
+// FIXME: these checks will fail if time goes backwards, e.g. NTP updates. We should have a generic bullet-proof method for comparing against Date.now(). http://crbug.com/320686
+shouldBeTrue("startTime <= fileTime");
+shouldBeTrue("fileTime <= endTime");
+// Test that Date instances are implicitly converted to numbers.
+shouldBe("(new File([], 'world.html', {lastModified: new Date(441532800000)})).lastModified", "441532800000");
+
+// Test the deprecated attribute lastModifiedTime.
kinuko 2013/11/20 08:01:22 lastModifiedTime -> lastModifiedDate ?
pwnall-personal 2013/11/20 09:51:07 Done. I'm so glad this name is going away :)
+shouldBeTrue("(new File([], 'world.html', {lastModified: 441532800000})).lastModifiedDate instanceof Date");
+shouldBe("(new File([], 'world.html', {lastModified: 441532800000})).lastModifiedDate.valueOf()", "441532800000");
+
// Test the number of expected arguments in the File constructor.
shouldBe("window.File.length", "2");

Powered by Google App Engine
This is Rietveld 408576698