Source/bindings/v8/V8Binding.h - Issue 74213009: File constructor understands lastModified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Binding.h

Issue 74213009: File constructor understands lastModified. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed feedback. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8Binding.h

diff --git a/Source/bindings/v8/V8Binding.h b/Source/bindings/v8/V8Binding.h

index 76250156a929c0716e6ee940f1b6fe4e139031cd..5e12d5e01631f3caff6e6eb438b6008e284729c2 100644

--- a/Source/bindings/v8/V8Binding.h

+++ b/Source/bindings/v8/V8Binding.h

@@ -646,7 +646,11 @@ namespace WebCore {

inline double toWebCoreDate(v8::Handle<v8::Value> object)

{

- return (object->IsDate() || object->IsNumber()) ? object->NumberValue() : std::numeric_limits<double>::quiet_NaN();

+ if (object->IsDate())

+ return v8::Handle<v8::Date>::Cast(object)->ValueOf();

+ if (object->IsNumber())

+ return object->NumberValue();

+ return std::numeric_limits<double>::quiet_NaN();

}

inline v8::Handle<v8::Value> v8DateOrNull(double value, v8::Isolate* isolate)