File constructor understands lastModified.

Source/bindings/v8/custom/V8BlobCustomHelpers.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 22 matching lines @@
 
 #include "bindings/v8/V8Binding.h"
 
 namespace WebCore {
 
 class BlobBuilder;
 
 // Shared code between the custom constructor bindings for Blob and File.
 namespace V8BlobCustomHelpers {
 
+// Parsed properties from a BlobPropertyBag or a FilePropertyBag.
+struct ParsedProperties {

[haraken, 2013/11/18 10:27:48]

We normally use class instead of struct for this kind of non-trivial structure.

[pwnall-personal, 2013/11/18 11:23:45]

Done.

I also turned the function that took a ParsedProperty reference into a method,
and shortened the code by a tiny bit.

+    String contentType;
+    String endings;
+
+    // False if this contains the properties of a BlobPropertyBag.
+    bool hasFileProperties;
+
+private:
+    double m_lastModifiedDate;
+#ifndef NDEBUG
+    bool m_hasLastModifiedDate;
+#endif // NDEBUG
+
+
+public:
+    void setLastModifiedDate(double);
+    void setDefaultLastModifiedDate();
+    double lastModifiedDate();
+
+    ParsedProperties(bool hasFileProperties);

[haraken, 2013/11/18 10:27:48]

Add 'explicit'.

[pwnall-personal, 2013/11/18 11:23:45]

Done.
Thank you!

+};
+
 // Extracts the "type" and "endings" properties out of the BlobPropertyBag passed to a Blob constructor.
 // http://www.w3.org/TR/FileAPI/#constructorParams
 // Returns true if everything went well, false if a JS exception was thrown.
-bool processBlobPropertyBag(v8::Local<v8::Value> propertyBag, const char* blobClassName, String& contentType, String& endings, v8::Isolate*);
+bool processBlobPropertyBag(v8::Local<v8::Value> propertyBag, const char* blobClassName, ParsedProperties&, v8::Isolate*);
 
-// Appends the blobParts passed to a Blob constructor into a BlobBuilder.
+// Appends the blobParts passed to a Blob or File constructor into a BlobBuilder.
 // http://www.w3.org/TR/FileAPI/#constructorParams
 // Returns true if everything went well, false if a JS exception was thrown.
 bool processBlobParts(v8::Local<v8::Object> blobParts, uint32_t blobPartsLength, const String& endings, BlobBuilder&, v8::Isolate*);
 
 } // namespace V8BlobCustomHelpers
 
 } // namespace WebCore
 
 #endif // V8BlobCustomHelpers_h