Ozone keyboard layout

ui/events/ozone/layout/keyboard_layout_engine_manager.h

Index: ui/events/ozone/layout/keyboard_layout_engine_manager.h
diff --git a/ui/events/ozone/layout/keyboard_layout_engine_manager.h b/ui/events/ozone/layout/keyboard_layout_engine_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..c052dbdb9e84034f142b5418932ab5fc585b4b0a
--- /dev/null
+++ b/ui/events/ozone/layout/keyboard_layout_engine_manager.h
@@ -0,0 +1,31 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_OZONE_PUBLIC_KEYBOARD_LAYOUT_ENGINE_MANAGER_H_
+#define UI_OZONE_PUBLIC_KEYBOARD_LAYOUT_ENGINE_MANAGER_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "ui/events/ozone/layout/events_ozone_layout_export.h"
+
+namespace ui {
+
+class KeyboardLayoutEngine;
+
+class EVENTS_OZONE_LAYOUT_EXPORT KeyboardLayoutEngineManager {
+ public:
+  virtual ~KeyboardLayoutEngineManager();
+
+  static void Create(scoped_ptr<KeyboardLayoutEngine> engine);

[Wez, 2014/12/09 07:00:34]

Why does the Create method take a KeyboardLayoutEngine and not actually create
anything?

[kpschoedel, 2014/12/09 19:58:44]

Not sure now (it may have been some offline comment), so I'll change it back.

[Wez, 2014/12/12 20:04:18]

If both of the methods are static, do you need the class in the header any more?

+  static KeyboardLayoutEngine* GetKeyboardLayoutEngine();

[Wez, 2014/12/09 07:00:33]

Does this return a global singleton?

[kpschoedel, 2014/12/09 19:58:44]

Not generally; it's normally owned by an OzonePlatform instance. This -Manager
just exists to break an otherwise circular dependency between ui/events/ozone
and ui/ozone, and the plan is to remove it by no longer calling layout from
within KeyEvent — see spang's previous comments.

[Wez, 2014/12/12 20:04:17]

Agreed w/ spang's comments re KeyEvent becoming just data!

Not sure what the issue is with this being a class vs a pair of static
functions, but if it's necessary then OK.

[kpschoedel, 2014/12/12 21:20:39]

I've started on this but didn't want it in simultaneously with the first Ozone
release, since it could have unexpected distracting side effects on other
platforms.

+
+ private:
+  KeyboardLayoutEngineManager(KeyboardLayoutEngine* engine);
+
+  static KeyboardLayoutEngineManager* instance_;
+  scoped_ptr<KeyboardLayoutEngine> keyboard_layout_engine_;
+};

[Wez, 2014/12/09 07:00:33]

DISALLOW_COPY_AND_ASSIGN

[kpschoedel, 2014/12/09 19:58:44]

Done.

+
+}  // namespace ui
+
+#endif  // UI_OZONE_PUBLIC_KEYBOARD_LAYOUT_ENGINE_MANAGER_H_