Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 742053002: Add missing dependencies to the GN build. (Closed)

Created:
6 years, 1 month ago by blundell
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, piman+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add missing dependencies to the GN build. The need for these dependencies was shaken out by the (local, so far) addition of public_configs to //mojo/public targets that need to be propagated throughout the build. Committed: https://crrev.com/24ab5d366622788672fccfcf9a7596110366f69c Cr-Commit-Position: refs/heads/master@{#305194}

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Fix typo #

Patch Set 4 : Typo fixes #

Patch Set 5 : Correct dependency for component build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/common/extensions/api/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/BUILD.gn View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/gpu/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/child/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M content/public/common/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M device/serial/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
blundell
rockot: //chrome/common/extensions and //device jam: //content Thanks!
6 years, 1 month ago (2014-11-20 11:44:22 UTC) #2
Ken Rockot(use gerrit already)
//chrome/common/extensions and //device lgtm
6 years, 1 month ago (2014-11-20 20:07:47 UTC) #3
jam
lgtm
6 years, 1 month ago (2014-11-20 21:16:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742053002/60001
6 years, 1 month ago (2014-11-20 21:39:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/19337)
6 years, 1 month ago (2014-11-20 21:45:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/742053002/80001
6 years, 1 month ago (2014-11-21 09:29:30 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-21 10:11:29 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 10:13:11 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/24ab5d366622788672fccfcf9a7596110366f69c
Cr-Commit-Position: refs/heads/master@{#305194}

Powered by Google App Engine
This is Rietveld 408576698