net/proxy/proxy_config_service_android.h - Issue 742023003: Enable using system proxy resolver for android webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_config_service_android.h

Issue 742023003: Enable using system proxy resolver for android webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address mnaganov's nit Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/net/aw_url_request_context_getter.cc ('K') | « android_webview/browser/net/aw_url_request_context_getter.cc ('k') | net/proxy/proxy_config_service_android.cc » ('j') | net/proxy/proxy_config_service_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/proxy/proxy_config_service_android.h

diff --git a/net/proxy/proxy_config_service_android.h b/net/proxy/proxy_config_service_android.h

index d642d37c73e4f8312f3a17eb7136527b498f4aa0..7f0b9dd5bf18e3c42cb36e4ffe31573f8bf0a9fa 100644

--- a/net/proxy/proxy_config_service_android.h

+++ b/net/proxy/proxy_config_service_android.h

@@ -64,6 +64,11 @@ class NET_EXPORT ProxyConfigServiceAndroid : public ProxyConfigService {

// Register JNI bindings.

static bool Register(JNIEnv* env);

+ // Android provides a local HTTP proxy that does PAC resolution. When this

eroman 2014/11/21 01:55:15 I guess this answers my previous question.

sgurun-gerrit only 2014/11/21 02:13:37 yes.

+ // setting is enabled, the proxy config service ignores the PAC URL and uses

+ // the local proxy for all proxy resolution.

+ void set_use_local_proxy(bool enabled);

// ProxyConfigService:

// Called only on the network thread.

virtual void AddObserver(Observer* observer) override;