Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 742003002: gn format: penalty-based line breaking WIP XXX

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
Reviewers:
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-more-disabled
Project:
chromium
Visibility:
Public.

Description

gn format: penalty-based line breaking WIP XXX BUG=348474

Patch Set 1 #

Patch Set 2 : futzing #

Patch Set 3 : wip #

Patch Set 4 : break into separate file #

Patch Set 5 : beginnings of annotation #

Patch Set 6 : wip, not sure about layout walk yet #

Patch Set 7 : futzing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+579 lines, -35 lines) Patch
M tools/gn/BUILD.gn View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M tools/gn/command_format.cc View 1 2 3 4 9 chunks +55 lines, -33 lines 0 comments Download
M tools/gn/format_test_data/032.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/gn.gyp View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
A tools/gn/line_breaker.h View 1 2 3 4 5 6 1 chunk +114 lines, -0 lines 0 comments Download
A tools/gn/line_breaker.cc View 1 2 3 4 5 6 1 chunk +204 lines, -0 lines 0 comments Download
A tools/gn/line_breaker_unittest.cc View 1 2 3 4 5 1 chunk +192 lines, -0 lines 0 comments Download
M tools/gn/parse_tree.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M tools/gn/parser.cc View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698